Auth policy #210
Merged
Auth policy #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te is older than 5 months
… roles decorators. User role decorators respect admin access. Added unified error handler for all API calls (invalid_sender).
…e to account-role checking
Closed
nhoening
commented
Oct 12, 2021
add documentation about account authorization
Flix6x
requested changes
Oct 23, 2021
There was a problem hiding this comment.
I finally got through this big PR, sorry for the delay. I advise to read through all of my comments first before addressing specific ones. This is a really nice and necessary PR. I added an 👀 symbol to my main concerns (e.g. clear naming of test users, and how we intend to use USEF roles in relation to access rights).
… conftest and use it where necessary; use dummy user instead of moving a user between accounts
… 2 will use the correct test user
Flix6x
reviewed
Oct 30, 2021
Flix6x
approved these changes
Oct 31, 2021
There was a problem hiding this comment.
Thanks for the explanations and changes. Besides addressing one typo, can you also open up a ticket for the incomplete service listings in API v2.0? This concept may need a significant revision so API users can see roles required and roles accepted listed separately.
|
I made #227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #160
Move towards a more account-based and more central authorization policy.
I split into a few commits for better readability.