New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load css and js from CDN #21
Conversation
Load most external css from cdn.
I haven't thought about the fallback yet. I guess the recommendation is easier for closed-source projects, as they don't have to consider licensing :D So there are three resources which we'll definitely keep in the source, so we'll mention them in NOTICES? |
As you pointed out earlier, these js and css files usually have very permissive licences. I don't think it matters from where they are served, from a copyright perspective. I made sure that all our css and js dependencies have permissive licences: all MIT, except Bokeh (BSD-3), Leaflet and rq-dashboard (both BSD-2). I could include a full list in the NOTICES file, if you'd like. |
I upgraded external css and js, and by doing so I was also able to remove one more css file: an ion.rangeslider skin that is now supported out of the box. We only use it on the control page (currently hidden), but it looks quite nice. The daterangepicker also looks nicer now, with users being nudged to use one of the default date ranges rather than set a custom date range. Otherwise, no noticeable changes as far as I can tell. |
What I did:
I read that, if CDN-based scripts were not loaded from CDN for whatever reason, you should fallback to a local copy. Is that functionality you would like to have?