try foreasting and scheduling jobs for up to one day #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remove the job if it needs memory
Flix6x
requested changes
Sep 30, 2021
| @@ -108,6 +108,7 @@ def create_forecasting_jobs( | |||
| custom_model_params=custom_model_params, | |||
| ), | |||
| connection=current_app.queues["forecasting"].connection, | |||
| ttl=24 * 60 * 60, # try up to one day | |||
There was a problem hiding this comment.
Looks to me like this should be a config setting rather than be hard coded. I'd also prefer to set the config setting as a timedelta (like FLEXMEASURES_PLANNING_TTL) and calling .total_seconds() on it here.
There was a problem hiding this comment.
It looks that way to me too, but I'm afraid of having too many config settings.
Flix6x
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After that let Reds remove the job if it needs memory.
This is to keep our Redis memory from growing large with intensive usage by services.