Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unchanged beliefs from BeliefsDataFrame before saving to db #194

Merged
merged 13 commits into from Oct 1, 2021
Merged

Drop unchanged beliefs from BeliefsDataFrame before saving to db #194

merged 13 commits into from Oct 1, 2021

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Sep 27, 2021

Closes #186

@Flix6x Flix6x self-assigned this Sep 27, 2021
@Flix6x Flix6x marked this pull request as ready for review September 29, 2021 20:33
nhoening
nhoening approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

requirements/app.in Outdated Show resolved Hide resolved
@nhoening
Copy link
Contributor

nhoening commented Oct 1, 2021

No changelog entry?

@Flix6x
Copy link
Contributor Author

Flix6x commented Oct 1, 2021 •
edited

I released timely-beliefs==1.4.5 and added a changelog entry. I also made the new feature optional, in case a developer explicitly decides they don't want to drop unchanged beliefs.

@Flix6x Flix6x changed the title Create draft PR for #186 Drop unchanged beliefs from BeliefsDataFrame before saving to db (issue #186) Oct 1, 2021
@Flix6x Flix6x changed the title Drop unchanged beliefs from BeliefsDataFrame before saving to db (issue #186) Drop unchanged beliefs from BeliefsDataFrame before saving to db Oct 1, 2021
@Flix6x Flix6x merged commit 664c958 into main Oct 1, 2021
@Flix6x Flix6x deleted the issue-186-Drop_unchanged_beliefs_from_BeliefsDataFrame_before_saving_to_db branch October 1, 2021 11:13
@Flix6x Flix6x added this to the 0.7.0 milestone Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

Drop unchanged beliefs from BeliefsDataFrame before saving to db
2 participants
@Flix6x @nhoening