Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fig bug: broken (dev) CLI command for adding a Sensor #176

Merged
merged 3 commits into from Sep 7, 2021
Merged

Fig bug: broken (dev) CLI command for adding a Sensor #176

merged 3 commits into from Sep 7, 2021

Conversation

create-issue-branch[bot]
Copy link
Contributor

closes #175

@Flix6x Flix6x self-assigned this Sep 7, 2021
@Flix6x Flix6x added this to the 0.6.1 milestone Sep 7, 2021
@Flix6x Flix6x marked this pull request as ready for review September 7, 2021 13:30
@Flix6x Flix6x requested a review from nhoening September 7, 2021 13:30
@Flix6x Flix6x changed the title Bug: broken (dev) CLI command for adding a Sensor Fig bug: broken (dev) CLI command for adding a Sensor Sep 7, 2021
@Flix6x Flix6x merged commit f30f1e1 into main Sep 7, 2021
@Flix6x Flix6x deleted the issue-175-Bug_broken_dev_CLI_command_for_adding_a_Sensor branch September 7, 2021 13:44
Flix6x added a commit that referenced this pull request Sep 7, 2021
@create-issue-branch @Flix6x
Backport PR #176: Fig bug: broken (dev) CLI command for adding a Sens…
8117cc1 
…or (#176)

Accept either a generic_asset or a generic_asset_id when initializing a Sensor.

* Create draft PR for #175

* Allow passing a GenericAsset or an id

* Changelog entry

Co-authored-by: Flix6x <Flix6x@users.noreply.github.com>
Co-authored-by: F.N. Claessen <felix@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
None yet
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.

Bug: broken (dev) CLI command for adding a Sensor
2 participants
@nhoening @Flix6x