Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offer asset grouping by location #148

Merged
merged 3 commits into from Jun 29, 2021
Merged

Offer asset grouping by location #148

merged 3 commits into from Jun 29, 2021

Conversation

create-issue-branch[bot]
Copy link
Contributor

closes #87

@nhoening nhoening marked this pull request as ready for review June 17, 2021 15:13
@nhoening nhoening modified the milestone: 0.6.0 Jun 17, 2021
@nhoening nhoening requested a review from Flix6x June 17, 2021 15:25
Flix6x
Flix6x approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoroughly read, though not tested, I could not fault this. Looks like a natural and useful extension of our earlier work.

@nhoening
Copy link
Contributor

Thanks for reviewing. I notice this is missing a changelog entry.

@nhoening nhoening merged commit 89fd9fe into main Jun 29, 2021
@nhoening nhoening deleted the issue-87-Offer_asset_grouping_by_location branch June 29, 2021 20:23
@Flix6x Flix6x added this to the 0.6.0 milestone Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Offer asset grouping by location
2 participants
@nhoening @Flix6x