Choose better weather forecasting horizons #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data; add forecast resolutions for 5T & 10T resolutions
Flix6x
approved these changes
May 12, 2021
| [ | ||
| job | ||
| for job in app.queues["forecasting"].jobs | ||
| if job.kwargs["timed_value_type"] != "Price" |
There was a problem hiding this comment.
Why are you checking for != "Price" instead of == "Weather"? Also in line 224.
| jobs = [ | ||
| job | ||
| for job in app.queues["forecasting"].jobs | ||
| if job.kwargs["timed_value_type"] != "Price" |
There was a problem hiding this comment.
Just flagging one more occurrence. Candidate util function?
| sorted(jobs, key=lambda x: x.kwargs["horizon"]), forecast_horizons | ||
| ): | ||
| assert job.kwargs["horizon"] == horizon | ||
| assert job.kwargs["start"] == parse_date(post_message["start"]) + horizon |
There was a problem hiding this comment.
A comment would be useful for this one, not self evident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If weather data is posted which is itself not forecasts, we should choose better forecasts for forecasting.
Also: add choices for horizons if the data resolution is smaller than 15 minutes.