Regression: analytics selections malfunctioning

[create-issue-branch]

closes #116

[nhoening]

So what is the difference between functions in flexmeasures.js and flexmeasures-modules.js? It isn't apparent to me at first glance...

[Flix6x]

One is a module and the other isn't. The bug had something to do with function definitions in js modules needing to be exported, but I don't know the fine details of it. So rather than exporting all function definitions in flexmeasures.js I think it is safer at this point to move out the recently introduced js content to a separate js module file, as I did in this PR. Otherwise I was worried about new side effects. Just to be clear, flexmeasures.js had not been a module type js file before, until we introduced the new (now to be separated) content.

[nhoening]

We still have a template which should switch over to the module:

± grep -r flexmeasures.js flexmeasures
flexmeasures/ui/templates/views/sensors.html:      import { subtract, thisMonth, lastNMonths } from "{{ url_for('flexmeasures_ui.static', filename='js/flexmeasures.js') }}";

Also, looking at that statement, it seems cleaner and more closer to the javascript module idea: import what you need. Shouldn't we do it the same way in base.html?

Other than that, I approve technically with this move.

I do, however, suggest better naming to move forward with this distinction (using modules has the main benefit to better organize the code):

• flexmeasures.js -> "ui-behaviours.js" (I actually want to factor out feature-specific code from here, like for the control page [lines 212-287], I'll make a ticket)
• flexmeasures-module.js -> "daterange-utils.js"

[Flix6x]

Good catch. The js module contents are actually not needed anywhere else currently, and I also prefer to import only what we need, so I'll stop importing our js module in our base.html. I'll also rename the module to "daterange-utils.js".

Just a note: this regression was caused by 1a238ef.

[Flix6x]

@meeseeksdev Hello

[lumberbot-app]

Look at me, @Flix6x, I'm Mr. Meeseeks!