Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn market_id attribute into consumption_price_sensor #774

Open
nhoening opened this issue Jul 26, 2023 · 1 comment
Open

Turn market_id attribute into consumption_price_sensor #774

nhoening opened this issue Jul 26, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation Scheduling

Comments

@nhoening
Copy link
Contributor

nhoening commented Jul 26, 2023

          I was [planning](https://github.com/FlexMeasures/flexmeasures/discussions/763#discussioncomment-6500979) to document which attributes are actually relevant, and market_id would have to be added to the list.

Is it possible to replace the name market_id with consumption-price-sensor, for instance, so we get more consistency?

Originally posted by @nhoening in #695 (comment)

As @Flix6x said, this needs a db migration, a few code replacements and maybe a check within plugins we have, like the one we use for simulations.

Plus, maybe mentioning in the upgraded documentation that consumption-price-sensor can also live outside of the flex context as an attribute.
Or (my preferred option), we use flex-context["consumption-price-sensor"], for more consistency. I want us to look up flex-model and flex-context on either sensor or asset, and this way we can get rid of market_id with a comprehensive solution which will work for all other things, as well (capacity_in_mw would be part of flex-model, see #335 - we could tackle these together)

@nhoening nhoening added this to the 0.16.0 milestone Jul 26, 2023
@nhoening nhoening added documentation Improvements or additions to documentation Scheduling labels Jul 26, 2023
@Flix6x Flix6x modified the milestones: 0.16.0, 0.17.0 Sep 20, 2023
@Flix6x Flix6x modified the milestones: 0.17.0, 0.18.0 Nov 7, 2023
@nhoening
Copy link
Contributor Author

@Flix6x suggests doing this together with other renaming work, see #911

@Flix6x Flix6x removed this from the 0.18.0 milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Scheduling
Projects
None yet
Development

No branches or pull requests

2 participants