Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop NaN values before saving to database #737

Open
Flix6x opened this issue Jun 20, 2023 · 0 comments
Open

Drop NaN values before saving to database #737

Flix6x opened this issue Jun 20, 2023 · 0 comments

Comments

@Flix6x
Copy link
Contributor

Flix6x commented Jun 20, 2023

For instance, in some places could have another column for the values with some NaN and dropping the NaN would drop, by default, any column having any NaN.

To fix this, we should use subset=["event_value"] to make sure that we only take the column event_value into account.

Regarding the the use case of storing NaN to the database, I think that as long as we can save a database with an irregular sampling rate, we are good to go.

Originally posted by @victorgarcia98 in #735 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant