New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default report timing should take into account knowledge horizon function #733
Comments
Specifically, I'm calling I guess a workaround could be to set the |
As an alternative, we could use the function This clearly will make computations/fetch time unnecessarily longer. |
It's an alternative worthy of consideration. The data fetching would indeed involve a second query, but only in case no end (offset) was explicitly passed. It also means we'd default to computing a report on the latest available complete set of input data, as opposed to on the latest set of input data that could have been known at that time (but without actually checking whether the input data is complete). Two considerations that come up (in any case):
|
Actually, we would need to ensure that the command is run after 12pm to ensure that we have data.
It might, a 'silly' case is when we list the sensor in the
No Regarding the use of knowledge functions, I don't think I would require to implement both the direct and the inverse functions just to have a default. In some cases, Using the bounds is an option. For instance, in the timedelta(days=x, hours=-y - 2), timedelta(days=x + 1, hours=-y + 2) In case of the function With that, an idea is to set the default |
The workaround of
Which doesn't respect the timezone of the output sensor. Given the "Europe/Amsterdam" timezone, I was expecting:
|
Oh, actually one could also just use the |
I agree, this is a good solution. Instead of a new setting, I wouldn't mind to just also use the |
When calling a report via CLI (
flexmeasures add report
), the default end time is now. This implicitly assumes an ex-post knowledge horizon, which does not yield a sensible end time for e.g. day-ahead markets. The default end time should passserver_now()
through the sensor's knowledge time function. Possibly the inverse function is needed, which may involve a loop (bounded by the knowledge horizon bounds) or an implementation of an analytical solution of the reverse function for each knowledge time function.The text was updated successfully, but these errors were encountered: