Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Reporter class #626

Closed
victorgarcia98 opened this issue Apr 5, 2023 · 3 comments · Fixed by #641
Closed

Add Reporter class #626

victorgarcia98 opened this issue Apr 5, 2023 · 3 comments · Fixed by #641
Assignees
@victorgarcia98
Projects
Reporting backend infrastructure

Comments

@victorgarcia98
Copy link
Contributor

victorgarcia98 commented Apr 5, 2023 •
edited

Add Reporter class with a compute_report method that computes a report given a report_config.
@victorgarcia98 victorgarcia98 created this issue from a note in Reporting backend infrastructure (To do) Apr 5, 2023
@victorgarcia98 victorgarcia98 changed the title Add Reporter class with a compute_report method that computes a report given a report_config. Add Reporter class Apr 5, 2023
@victorgarcia98 victorgarcia98 self-assigned this Apr 5, 2023
@victorgarcia98
Copy link
Contributor Author

victorgarcia98 commented Apr 6, 2023 •
edited

As for standardization of the classes Reporter, Scheduler and Forecaster, I would refactor the methods compute_report, compute_schedule and compute_forecast respectively into just compute. What do you think @nhoening and @Flix6x?

@nhoening
Copy link
Contributor

nhoening commented Apr 6, 2023

I agree, good thinking!

@Flix6x
Copy link
Contributor

Flix6x commented Apr 7, 2023

Yes please. One caveat: we should nicely deprecate the old function name, instead of doing a "breaking change" rename.

@victorgarcia98 victorgarcia98 linked a pull request Apr 14, 2023 that will close this issue
Creation of Reporter class #641
Merged
@victorgarcia98 victorgarcia98 mentioned this issue Apr 14, 2023
Merged
@victorgarcia98 victorgarcia98 moved this from To do to In progress in Reporting backend infrastructure Apr 21, 2023
Reporting backend infrastructure automation moved this from In progress to Done May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@victorgarcia98 victorgarcia98

Labels
None yet
Projects
Reporting backend infrastructure
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Creation of Reporter class FlexMeasures/flexmeasures
3 participants
@nhoening @Flix6x @victorgarcia98