Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate account when non-admins create assets #487

Closed
nhoening opened this issue Aug 25, 2022 · 2 comments · Fixed by #488
Closed

Validate account when non-admins create assets #487

nhoening opened this issue Aug 25, 2022 · 2 comments · Fixed by #488
Assignees
@nhoening
Labels
API bug Something isn't working UI
Milestone
0.11.0

Comments

@nhoening
Copy link
Contributor

nhoening commented Aug 25, 2022 •
edited

Users with the role account-admin can create assets, but that is currently not limited to their account.

This should happen in the Marshmallow validation.

As a corollary, we currently do not let these users in the UI see the button to create assets. That should be fixed, as well.
@nhoening nhoening added this to the 0.11.0 milestone Aug 25, 2022
@nhoening nhoening added bug Something isn't working API UI labels Aug 25, 2022
@nhoening nhoening self-assigned this Aug 25, 2022
@nhoening nhoening linked a pull request Aug 25, 2022 that will close this issue
validate that user can set the account on an asset #488
Merged
@Flix6x
Copy link
Contributor

Flix6x commented Aug 25, 2022

Why would the button to create assets be hidden from them? Aren't they still allowed to create assets belonging to their own account?

@nhoening
Copy link
Contributor Author

My bad, it should have been clearer that this is a current deficiency I found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nhoening nhoening

Labels
API bug Something isn't working UI
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

validate that user can set the account on an asset FlexMeasures/flexmeasures
2 participants
@nhoening @Flix6x