Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensible defaults for searching for beliefs (e.g. most recent beliefs) #311

Closed
Flix6x opened this issue Jan 12, 2022 · 4 comments · Fixed by #312
Closed

Sensible defaults for searching for beliefs (e.g. most recent beliefs) #311

Flix6x opened this issue Jan 12, 2022 · 4 comments · Fixed by #312

Comments

@Flix6x
Copy link
Contributor

Flix6x commented Jan 12, 2022

most_recent_beliefs_only=True seems like a sensible default for Sensor.search_beliefs. I'd propose to keep most_recent_beliefs_only=False for TimedBelief.search.

(Inspired by discussion in #307.)

@nhoening
Copy link
Contributor

Why do you propose to use False in TimedBelief.search?

@Flix6x
Copy link
Contributor Author

Flix6x commented Jan 12, 2022

I like our starting point (from timely beliefs) in that the defaults for all search parameters have the same connotation: "If you don't set any, you get everything". Here we're discussing to deviate from that logic to: "If you don't set any, you get the most recent beliefs about all events". I guess there's something to be said for keeping the defaults of both (FlexMeasures) functions in sync.

@Flix6x Flix6x self-assigned this Jan 12, 2022
@Flix6x Flix6x linked a pull request Jan 12, 2022 that will close this issue
@nhoening
Copy link
Contributor

I found this comment difficult to translate into what actions you propose on FM and TB levels.

@Flix6x
Copy link
Contributor Author

Flix6x commented Jan 12, 2022

I propose to change the defaults for FlexMeasures only, and keep timely-beliefs as is.

@Flix6x Flix6x added this to To do in Support Sensor and Asset diversity via automation Jan 17, 2022
@Flix6x Flix6x closed this as completed Jan 17, 2022
Support Sensor and Asset diversity automation moved this from To do to Done Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants