Implement GenericAsset crud

[nhoening]

Results:

• The dashboard shows the user's generic assets (which all refer to an old-style asset).
• The pop-up showing the latest data of course only shows one sensor right now, not sure which to choose if there are more. Maybe a simple heuristic.
• Generic assets can be edited and created, just like the old-style assets (not sure what to do about attributes, maybe ignore for now).

For this, we'll copy the old asset API and Crud. The new one should use modern authorization logic (we'll add ACLs to the GenericAsset class). The old API and Crud are noted for deprecation.

[Flix6x]

Attaching some of my thoughts:

• Replicating CRUD functionality in our new data model means we should do this for both GenericAssets and Sensors.
• I think we can, if needed, limit the fields we allow users to change, at least until we have completed the move to the new data model. But before we start the work, we should make a list of UI editable properties of GenericAssets and Sensors.
• The list of GenericAssets may also include ones that have no corresponding old Asset.
• A plot with the latest state doesn't make sense for the GenericAsset crud page. It makes sense for the Sensor crud page.

[nhoening]

I wouldn't advise we do both generic assets and sensors in the same PR. My thought was generic assets can go first because the dashboard should show them. Maybe you have a better reason to start with sensors.

The latest measurement I was referring to is part of that dashboard.

[Flix6x]

If mapping is the only goal, then I concur. Bare in mind that a significant part of the former editable fields are moving to the Sensor. These are the current fields that can be changed in the UI, and where they will move: - Display name -> Sensor attribute and GenericAsset attribute (will be able to be set independently) - Capacity in MW -> Sensor attribute - Unit -> Sensor column - Resolution -> Sensor column - Latitude -> GenericAsset column - Longitude -> GenericAsset column - Market -> Sensor attribute So I guess if this PR is about GenericAssets only, than only the display name and location can be changed. (Which is fine I think, for 1 PR.) Do you want to involve the latest state plot here, too? If so, how would you suggest to tackle it? Would you look for the GenericAsset's power sensors and report only one, or want to sum over potentially multiple power sensors belonging to the GenericAsset?

…

On Sat, Nov 27, 2021, 19:46 Nicolas Höning ***@***.***> wrote: I wouldn't advise we do both generic assets and sensors in the same PR. My thought was generic assets can go first because the dashboard should show them. Maybe you have a better reason to start with sensors. The latest measurement I was referring to is part of that dashboard. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#247 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHJ5BS5REJJPUVDMPB6DCH3UOERORANCNFSM5I4LUIXA> .

[nhoening]

I chose the map as a user-facing goal, because every PR should have one to work towards, if possible. For this PR that is possible, for your recent PRs it was of course more difficult.
Happy to hear if there is a better one, e.g. for the Sensor case.

[nhoening]

The list of GenericAssets may also include ones that have no corresponding old Asset

I agree, I believe that old and new assets are mirrored pretty well, so I thought I only offer editing new assets. I don't plan to carry edits back to the old style assets.

[nhoening]

Finding and even summing over power sensors sounds like a good idea to me.
We can in the future work towards an Asset model which identifies a primary sensor, but we can do so if we need it.

[nhoening]

Actually, I now see that I can split the asset work in two PRs - replacing the dashboard and writing a new CRUD:

I believe I'd like to start with the dashboard work, I believe it's simpler.

I can also keep the old dashboard+queries around, but I'm not sure what for.

So I'd update the left stack, and write a new right stack.

[Flix6x]

That sounds good to me. Would you consider splitting this into two smaller PRs then?