Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: broken link on asset page for some assets #19

Closed
Flix6x opened this issue Feb 9, 2021 · 2 comments · Fixed by #20
Closed

Bug: broken link on asset page for some assets #19

Flix6x opened this issue Feb 9, 2021 · 2 comments · Fixed by #20
Assignees
Labels
bug Something isn't working UI

Comments

@Flix6x
Copy link
Contributor

Flix6x commented Feb 9, 2021

What is the error?

IndexError : "list index out of range"

When does it happen?

In two places, when clicking on "Analyse this asset", on the assets page and on the asset edit page. They lead to the analytics page where the error is then shown.

Upon further analysis, the asset_name seems to be url encoded twice, making a space turn into %2520 rather than %20. The asset can still be viewed in the analytics view by selecting from the list of assets there.

@Flix6x Flix6x added bug Something isn't working UI labels Feb 9, 2021
@Flix6x Flix6x self-assigned this Feb 9, 2021
@create-issue-branch
Copy link
Contributor

@Flix6x Flix6x linked a pull request Feb 9, 2021 that will close this issue
@nhoening
Copy link
Contributor

Please give more information to reproduce this: an actual asset and the browser where this happens.

I am trying this in Firefox with an asset that seems to have a space in its name, and it's working fine:

https://staging.a1-bvp.com/assets/58/ (for "Jeju Haenyeo Museum - charger 1") leads to https://staging.a1-bvp.com/analytics?resource=jeju-haenyeo-museum---charger-1

This seems not to be what you describe ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants