[CLI] flexmeasures show beliefs entity path in case of duplicated sensors
#1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Flix6x
requested changes
Mar 29, 2024
… their entity path. Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Flix6x
reviewed
Apr 2, 2024
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
…es' into cli/improve-duplicate-sensor-names
Flix6x
requested changes
Apr 6, 2024
Comment on lines
+241
to
+252
| Examples: | ||
| >>> reduce_entity_paths([["Account1", "Asset1"], ["Account2", "Asset2"]]) | ||
| [["Account1", "Asset1"], ["Account2", "Asset2"]] | ||
|
|
||
| >>> reduce_entity_paths([["Asset1"], ["Asset2"]]) | ||
| [["Asset1"], ["Asset2"]] | ||
|
|
||
| >>> reduce_entity_paths([["Asset1"], ["Asset1"]]) | ||
| [["Asset1"], ["Asset1"]] | ||
|
|
||
| >>> reduce_entity_paths([["Asset1", "Asset2"], ["Asset1"]]) | ||
| [["Asset1"], ["Asset1", "Asset2"]] |
There was a problem hiding this comment.
None of these examples seem to actually reduce anything.
* docs: clarify flag option Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: improve title Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: harmonize how two CLI options work together (show path vs. show ID) Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: harmonize how paths are shown in case of having only a part of the sensor names be duplicated Signed-off-by: F.N. Claessen <felix@seita.nl> * refactor: repurpose util function Signed-off-by: F.N. Claessen <felix@seita.nl> * refactor: simplify logic Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: fix typos Signed-off-by: F.N. Claessen <felix@seita.nl> --------- Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Flix6x
approved these changes
May 6, 2024
Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The command
flexmeasures show beliefsadds the sensor ID in case of trying to export sensors with the same name. However, if we want to hand this over to a third-party, it would be nicer if it included the asset names or its ancestry.This PR changes the appended sensor ID to a string representing the "path" of the entity.
Related Items
Closes #1023