From 5a9a64939a661f6b60acdf04e101f7cbc1827061 Mon Sep 17 00:00:00 2001
From: "create-issue-branch[bot]"
 <53036503+create-issue-branch[bot]@users.noreply.github.com>
Date: Tue, 20 Jul 2021 10:46:35 +0200
Subject: [PATCH] Document how plugins can add a custom favicon (#152)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Document how to use a custom favicon in plugins.


* Create draft PR for #140

* add documentation on how plugins can show their custom favicons

* Do not override app's static url path

* Plural to singular

* Update MIME type for ico extension

Co-authored-by: nhoening <nhoening@users.noreply.github.com>
Co-authored-by: Nicolas Höning <nicolas@seita.nl>
Co-authored-by: F.N. Claessen <felix@seita.nl>
---
 documentation/changelog.rst   |  1 +
 documentation/dev/plugins.rst | 38 +++++++++++++++++++++++++++++++++--
 2 files changed, 37 insertions(+), 2 deletions(-)

diff --git a/documentation/changelog.rst b/documentation/changelog.rst
index 28555a600..15346eb73 100644
--- a/documentation/changelog.rst
+++ b/documentation/changelog.rst
@@ -18,6 +18,7 @@ Infrastructure / Support
 
 * Add possibility to send errors to Sentry [see `PR #143 <http://www.github.com/SeitaBV/flexmeasures/pull/143>`_]
 * Add CLI task to monitor if tasks ran successfully and recently enough [see `PR #146 <http://www.github.com/SeitaBV/flexmeasures/pull/146>`_]
+* Document how to use a custom favicon in plugins [see `PR #152 <http://www.github.com/SeitaBV/flexmeasures/pull/152>`_]
 
 
 v0.5.0 | June 7, 2021
diff --git a/documentation/dev/plugins.rst b/documentation/dev/plugins.rst
index 3606a2ed4..59044bd93 100644
--- a/documentation/dev/plugins.rst
+++ b/documentation/dev/plugins.rst
@@ -10,7 +10,7 @@ A FlexMeasures plugin works as a `Flask Blueprint <https://flask.palletsprojects
 .. todo:: We'll use this to allow for custom forecasting and scheduling algorithms, as well.
 
 
-How it works 
+How it works
 ^^^^^^^^^^^^^^
 
 Use the config setting :ref:`plugin-config` to point to your plugin(s).
@@ -121,7 +121,7 @@ Starting the template with ``{% extends "base.html" %}`` integrates your page co
 We'd name this file ``our_client_base.html``. Then, we'd extend our page template from ``our_client_base.html``, instead of ``base.html``.
 
 
-Using other files in your plugin
+Using other code files in your plugin
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 Say you want to include other Python files in your plugin, importing them in your ``__init__.py`` file.
@@ -138,6 +138,40 @@ This can be done if you put the plugin path on the import path. Do it like this
     from my_other_file import my_function
 
 
+Using a custom favicon icon
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+The favicon might be an important part of your customisation. You probably want your logo to be used.
+
+First, your blueprint needs to know about a folder with static content (this is fairly common ― it's also where you'd put your own CSS or JavaScript files):
+
+.. code-block:: python
+
+    our_client_bp = Blueprint(
+        "our_client",
+        "our_client",
+        static_folder="our_client/ui/static",
+    )
+
+Put your icon file in that folder. The exact path may depend on how you set your plugin directories up, but this is how a blueprint living in its own directory could work.
+
+Then, overwrite the ``/favicon.ico`` route which FlexMeasures uses to get the favicon from:
+
+.. code-block:: python
+
+    from flask import send_from_directory
+
+    @our_client_bp.route("/favicon.ico")
+    def favicon():
+        return send_from_directory(
+            our_client_bp.static_folder,
+            "img/favicon.png",
+            mimetype="image/png",
+        )
+
+Here we assume your favicon is a PNG file. You can also use a classic `.ico` file, then your mime type probably works best as ``image/x-icon``.
+
+
 Validating arguments in your CLI commands with marshmallow
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^