Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bindings code generation for nested types #2591

Merged
merged 2 commits into from May 15, 2024

Conversation

GoaLitiuM
Copy link
Contributor

Fixes #2582, and has better fix for #2590 to avoid conflicting names in following scenarios:

API_CLASS() class GAME_API Item : public Script
{
    // ...
    API_STRUCT() struct GAME_API Attribute
    {
        // ...
        API_ENUM() enum MyEnum
        {
            E1, E2,
        };
    };
    // ...
};
API_CLASS() class GAME_API DifferentItem : public Script
{
    // ...
    API_STRUCT() struct GAME_API Attribute
    {
        // ...
        API_ENUM() enum MyEnum
        {
            E3, E4,
        };
    };
    // ...
};

@cNori cNori mentioned this pull request May 11, 2024
@mafiesto4 mafiesto4 added this to the 1.9 milestone May 14, 2024
@flaxtechnology flaxtechnology merged commit fd871ce into FlaxEngine:master May 15, 2024
10 checks passed
@GoaLitiuM GoaLitiuM deleted the nested_type_fixes branch May 15, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bindings generator] generates invalid code on c# side
4 participants