Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a tag while some assets (Actor/JSON assets) have reference that tag will not delete it in their editor property #2547

Open
alcoranpaul opened this issue May 3, 2024 · 2 comments
Labels
content Game content and assets level Level building tools and components.

Comments

@alcoranpaul
Copy link

Issue description:
When deleting a tag, in Layers and Tag setting, and some actor has that tag, the actor properties panel still have that tag existing.

Steps to reproduce:

  1. Add a tag via Properties panel of some actor and do not add that tag to the actor
  2. Add another tag but it will be the child of the previous tag and add that tag to the actor
  3. Delete the parent tag via Layers and Tag Setting
  4. Reload project (since deleting a tag in the Settings will not change in real time)
  5. Go to the Actor that was added the tag and see that it is glitched
  • Layers and Tag setting would not have the parent tag but the child would still exists resulting in a glitched scenario
    image

  • Upon deleting the either the parent/child/both tag will remove the glitch.

  • but while either or both tags is has not been deselected on an Actor, it will result in Actor Properties panel to still show that deleted parent/child/both tag
    image
  • Also, in my project there are custom JSON assets that has a Tag parameter.
  • it shows the same behavior as the Actor properties panel

Workaround
Deselect the desired Tag and Delete it from Tags and Layers setting

Expected

  • When deleting a parent tag/or some tag in Layers and Tag setting while some actor has the child tag, will result in that tag being removed in real time and will be reflected the project. (Ex. In Actors properties panel and JSON assets tag ref)

Proposed solution
When removing a tag in Layers and Tag setting it will (In real time without reloading project)

  • Remove that child/parent tag that some actors has reference to
  • or A prompt that warns the developer that there are some actors that has the child tag and the parent cannot be deleted

Flax version:
Master

@alcoranpaul alcoranpaul changed the title Deleting a parent tag while some actor has the child tag Deleting a tag while some assets (Actor/JSON assets) have reference that tag will not delete it in their editor property May 3, 2024
@alcoranpaul
Copy link
Author

What I mean by editor property is this in Actor or JSON asset
image

@mafiesto4
Copy link
Member

The current design allows assets from game and plugin projects to provide tags without need to specify them in layers&tags asset. Maybe here we could scan content and remove tags from content when deleting them from the layers&tags asset.

@mafiesto4 mafiesto4 added level Level building tools and components. content Game content and assets labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Game content and assets level Level building tools and components.
Projects
None yet
Development

No branches or pull requests

2 participants