New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage the Token types of search parameters. #328
Comments
Good catch, @whyfate, seems like the indexing for token search parameters should be consolidated so that we handle all token search parameters similar independent of their underlying data type. |
What's your thoughts on this @whyfate, is this something that is time critical to you at the moment? I'm guessing not based on the date for this issue. If not I will put it into the 2.0 release and then we'll reconsider it then |
It's not important at the moment. |
When i read the
Spark
's source code,I found that thecode
property was added when saved thesearchindex
of theboolean
type,like thishttps://github.com/FirelyTeam/spark/blob/stu3/master/src/Spark.Engine/Search/ElementIndexer.cs#L354
and I read the fhir's doc
http://build.fhir.org/search.html#token
Token search parameters are used for the following data types:
boolean
、code
、uri
、Coding
and soon.but the
code
、uri
not addcode
property likeboolean
?https://github.com/FirelyTeam/spark/blob/stu3/master/src/Spark.Engine/Search/ElementIndexer.cs#L190
https://github.com/FirelyTeam/spark/blob/stu3/master/src/Spark.Engine/Search/ElementIndexer.cs#L447
As a result, when querying Token type, a
plainStringQueries
is required.https://github.com/FirelyTeam/spark/blob/stu3/master/src/Spark.Mongo/Search/Searcher/CriteriaMongoExtensions.cs#L360
It's a question for me.
Could give me an answer,thinks.
The text was updated successfully, but these errors were encountered: