Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage the Token types of search parameters. #328

Open
whyfate opened this issue Dec 14, 2020 · 3 comments
Open

Storage the Token types of search parameters. #328

whyfate opened this issue Dec 14, 2020 · 3 comments

Comments

@whyfate
Copy link
Contributor

whyfate commented Dec 14, 2020

When i read the Spark's source code,I found that the code property was added when saved the searchindex of the boolean type,like this

{
   "active":{
        "code": true 
     }
}

https://github.com/FirelyTeam/spark/blob/stu3/master/src/Spark.Engine/Search/ElementIndexer.cs#L354
and I read the fhir's doc
http://build.fhir.org/search.html#token
Token search parameters are used for the following data types:
booleancodeuriCoding and soon.

but the codeuri not add code property like boolean?
https://github.com/FirelyTeam/spark/blob/stu3/master/src/Spark.Engine/Search/ElementIndexer.cs#L190
https://github.com/FirelyTeam/spark/blob/stu3/master/src/Spark.Engine/Search/ElementIndexer.cs#L447
As a result, when querying Token type, a plainStringQueries is required.
https://github.com/FirelyTeam/spark/blob/stu3/master/src/Spark.Mongo/Search/Searcher/CriteriaMongoExtensions.cs#L360

It's a question for me.
Could give me an answer,thinks.

@whyfate whyfate changed the title On the storage of Token types in search parameters. Storage the Token types of search parameters. Dec 14, 2020
@kennethmyhra
Copy link
Collaborator

Good catch, @whyfate, seems like the indexing for token search parameters should be consolidated so that we handle all token search parameters similar independent of their underlying data type.

@kennethmyhra kennethmyhra added this to To do in R2021.1 via automation Feb 19, 2021
@kennethmyhra kennethmyhra added this to To do in R2021.2 via automation Apr 12, 2021
@kennethmyhra kennethmyhra removed this from To do in R2021.1 Apr 12, 2021
@kennethmyhra kennethmyhra removed this from To do in R2021.2 May 10, 2021
@kennethmyhra kennethmyhra added this to To do in Release v1.5.6 via automation May 10, 2021
@kennethmyhra kennethmyhra removed this from To do in Release v1.5.6 Jun 29, 2021
@kennethmyhra kennethmyhra added this to To do in Release v1.5.7 via automation Jun 29, 2021
@kennethmyhra kennethmyhra removed this from To do in Release v1.5.7 Jul 9, 2021
@kennethmyhra kennethmyhra added this to To do in Release v1.5.9 via automation Jul 9, 2021
@kennethmyhra
Copy link
Collaborator

What's your thoughts on this @whyfate, is this something that is time critical to you at the moment? I'm guessing not based on the date for this issue.

If not I will put it into the 2.0 release and then we'll reconsider it then

@whyfate
Copy link
Contributor Author

whyfate commented Aug 16, 2021

It's not important at the moment.

@kennethmyhra kennethmyhra removed this from To do in Release v1.5.9 Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants