Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET interaction support in Batch transactions #305

Open
andy-a-o opened this issue Nov 29, 2020 · 1 comment
Open

GET interaction support in Batch transactions #305

andy-a-o opened this issue Nov 29, 2020 · 1 comment
Assignees

Comments

@andy-a-o
Copy link
Contributor

Is your feature request related to a problem? Please describe.
https://www.hl7.org/fhir/STU3/http.html#2.21.0.5.2

For example, this request leads to 500 response:

{
  "type": "transaction",
  "entry": [
    {
      "request": {
        "method": "GET",
        "url": "Observation?code=http://loinc.org|3141-9&patient=Patient/1096"
      }
    },
    {
      "fullUrl": "http://localhost:5000/fhir/Observation/70",
      "resource": {
        "id": "70",
        "meta": {
          "tag": [
            {
              "system": "http://projectcrucible.org",
              "code": "testdata"
            }
          ]
        },
        "status": "final",
        "code": {
          "coding": [
            {
              "system": "http://loinc.org",
              "code": "3141-9"
            }
          ]
        },
        "subject": {
          "reference": "Patient/1096"
        },
        "valueQuantity": {
          "value": 105,
          "unit": "kg",
          "system": "http://unitsofmeasure.org"
        },
        "resourceType": "Observation"
      },
      "request": {
        "method": "PUT",
        "url": "Observation/70"
      }
    },
    {
      "fullUrl": "urn:uuid:246a78d3-dd8b-492f-bcf4-9631b1969377",
      "resource": {
        "meta": {
          "tag": [
            {
              "system": "http://projectcrucible.org",
              "code": "testdata"
            }
          ]
        },
        "status": "final",
        "code": {
          "coding": [
            {
              "system": "http://loinc.org",
              "code": "8302-2"
            }
          ]
        },
        "subject": {
          "reference": "Patient/1096"
        },
        "valueQuantity": {
          "value": 177,
          "unit": "cm",
          "system": "http://unitsofmeasure.org"
        },
        "resourceType": "Observation"
      },
      "request": {
        "method": "POST",
        "url": "Observation"
      }
    },
    {
      "request": {
        "method": "DELETE",
        "url": "Observation/73"
      }
    }
  ],
  "resourceType": "Bundle"
}

Describe the solution you'd like
GET interaction is supported as a part of batch transaction.

Failed tests
TransactionAndBatchTest (XFER4)

@kennethmyhra kennethmyhra added this to To do in Release v1.5.6 via automation Jun 1, 2021
@kennethmyhra kennethmyhra removed this from To do in Release v1.5.6 Jun 29, 2021
@kennethmyhra kennethmyhra added this to To do in Release v1.5.7 via automation Jun 29, 2021
@kennethmyhra kennethmyhra removed this from To do in Release v1.5.7 Jul 9, 2021
@kennethmyhra kennethmyhra added this to To do in Release v1.5.9 via automation Jul 9, 2021
@kennethmyhra kennethmyhra moved this from To do to In progress in Release v1.5.9 Jul 15, 2021
kennethmyhra added a commit that referenced this issue Sep 5, 2021
This adds support for GET interaction in batch/transaction bundles.

Fixes #305
@kennethmyhra kennethmyhra moved this from In progress to Review in progress in Release v1.5.9 Sep 5, 2021
kennethmyhra added a commit to incendilabs/plan_executor that referenced this issue Sep 5, 2021
Since we noe have implemented support for GET interactions in
batch/transaction bundles we can now enable these.

Related issue: FirelyTeam/spark#305.
kennethmyhra added a commit that referenced this issue Sep 5, 2021
This adds support for GET interaction in batch/transaction bundles.

Related to #305
kennethmyhra added a commit that referenced this issue Sep 5, 2021
This adds support for GET interaction in batch/transaction bundles.

Related to #305
@kennethmyhra kennethmyhra moved this from Review in progress to To do in Release v1.5.9 Sep 5, 2021
@kennethmyhra
Copy link
Collaborator

kennethmyhra commented Sep 5, 2021

Shaved off some yaks, still some more to go.

  • GET request which translates to a search should be a Bundle.type="searchset" within one (1) entry.

kennethmyhra added a commit that referenced this issue Sep 5, 2021
This adds support for GET interaction in batch/transaction bundles.

Related to #305
@kennethmyhra kennethmyhra removed this from To do in Release v1.5.9 Sep 18, 2021
@kennethmyhra kennethmyhra added this to To do in Release 1.5.10 via automation Sep 18, 2021
@kennethmyhra kennethmyhra removed this from To do in Release 1.5.10 Oct 19, 2021
@kennethmyhra kennethmyhra added this to To do in Release 1.5.11 via automation Oct 19, 2021
@kennethmyhra kennethmyhra removed this from To do in Release 1.5.11 Feb 8, 2022
@kennethmyhra kennethmyhra added this to To do in Release 1.5.12 via automation Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants