Invalid Search parameter definition

[brianpos]

Invalid search parameter definition in http://hl7.org/fhir/SearchParameter/Observation-value-date in R4B:
value.as(DateTime) | value.as(Period)
should be
value.as(DateTime) | value.as(Period)
(admitedly this is how it is defined in the spec itself)
https://hl7.org/fhir/r4b/observation.html#search

https://github.com/FirelyTeam/firely-net-sdk/blob/168747b66d1bbd1733913436950fdb0a79fac984/src/Hl7.Fhir.R4B/Model/Generated/Template-ModelInfo.cs#L1757

[brianpos]

While correcting some of this, maybe consider the others listed in here...
https://github.com/brianpos/Hl7.Fhir.FhirPath.Validator/blob/b13ea45b5776ca329cf411c60b727a0f73eaa2bd/src/Test.FhirPath.Validator/SearchParametersFromR4.cs#L37

[mmsmits]

You mean it's currently
value.as(DateTime) | value.as(Period)
and it should be
value.​ofType(dateTime) | value.​ofType(Period)

or the other way around?

[brianpos]

the fhirpath typename for datetime is dateTime

[mmsmits]

Refinement:

• First check with FS team if there is a list they use. @eugene-blokhin ?
• Alter the codegen to correct these issues.
• Check if these issues need to be corrected for all FHIR version
• Unit test in the SDK to check if the generator stays consistent after this change.

[alexzautke]

In R5 we only fixed invalid Composite search parameter definitions. We din't stumble yet over this. At least in R4 no SearchParameter that is relevant for US compliancy is affected.