Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] In 10.0.0.4 the color of the icon in the address bar is always "active"/"translate page" #799

Open
1 task done
vitalii2011 opened this issue Mar 1, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@vitalii2011
Copy link

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. Click on '...'

Expected Result

Image 001
Image 002

Actual Result

Screenshots or Videos

No response

Additional Context

No response

Operating System

Windows

Operating System Version

No response

Web Browser

Firefox

Browser Version

No response

Extension Version

10.0.0.4

What are you doing?

  • I am reporting a bug
@vitalii2011 vitalii2011 added the bug Something isn't working label Mar 1, 2024
@FilipePS
Copy link
Owner

FilipePS commented Mar 1, 2024

What theme are you using?

@vitalii2011
Copy link
Author

@JackASil
Copy link

JackASil commented Mar 2, 2024

same, using Matte Black (White) from [Elijah Lopez] https://addons.mozilla.org/firefox/addon/matte-black-theme/

@FilipePS
Copy link
Owner

FilipePS commented Mar 5, 2024

I made some corrections to the colors, but the big problem is that these themes define the icons_attention property with a color very similar to the color of the toolbar_field_text property, so it is difficult to differentiate.
Maybe in the future I will change the extension icon so that it fills with the icons_attention color (in the same way as with the favorite star).

@vitalii2011
Copy link
Author

But before 10.0.0.4 this problem did not exist. Or are "some corrections to the colors" very important?

@FilipePS
Copy link
Owner

FilipePS commented Mar 5, 2024

But before 10.0.0.4 this problem did not exist. Or are "some corrections to the colors" very important?

For the Beautiful Opera Dark theme you can see the difference in colors when translated, but with the Matte Black (White) theme the difference is very subtle.

The reason the color difference was more noticeable before (in those themes) is because the extension was using the wrong transparency.

The color corrections made from version 10.0 are important, there were situations where the icon was invisible, for example.

Although version 10.0.1 has not yet been reviewed by Mozilla, you can install the self-hosted version in advance, available here:
https://github.com/FilipePS/Traduzir-paginas-web/releases/tag/v10.0.1.0

@vitalii2011
Copy link
Author

  • In 10.0.1.1 (on the big screen the difference is very difficult to discern):
    Image 002
    Image 003
    In 9.9.0.30:
    Image 001
    Image 004
    I'll switch back to this version for now.
  • In any case, thanks for the must-have addon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants