Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should ignore Stable API parameters #3121

Open
b1ron opened this issue Jul 26, 2023 · 2 comments · May be fixed by #4067
Open

We should ignore Stable API parameters #3121

b1ron opened this issue Jul 26, 2023 · 2 comments · May be fixed by #4067
Assignees
@AlekSi
Labels
code/bug Some user-visible feature works incorrectly community Issues and PRs assigned to community members not ready Issues that are not ready to be worked on; PRs that should skip CI

Comments

@b1ron
Copy link
Contributor

b1ron commented Jul 26, 2023 •
edited by AlekSi

FerretDB version

v1.7.0

Backend

PostgreSQL

Environment

  • OS:
  • Deployment:
  • Deployment details:

What did you do?

See repro in #3120.

This is not exactly a bug because it's a specific MongoDB parameter which will prevent a client from using commands that are deemed "unstable". The stable API encompasses a subset of commands that will not break your application when you upgrade. However, if a client has these parameters enabled it will send them in a command document as top-level fields. We should ignore them.

What did you expect to see?

I think it's the same issue as #3010, extracting parameters breaks stuff.

What did you see instead?

dance_ferretdb  |         "errmsg": "insert: unknown field \"apiVersion\"",
dance_ferretdb  |         "code": 9,
dance_ferretdb  |         "codeName": "FailedToParse"
@b1ron b1ron added code/bug Some user-visible feature works incorrectly not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jul 26, 2023
@b1ron b1ron changed the title We fail to parse the apiVersion field We should ignore Stable API parameters Jul 27, 2023
@AlekSi AlekSi mentioned this issue Dec 6, 2023
Closed
9 tasks
@Evengard Evengard mentioned this issue Feb 12, 2024
Open
@b1ron b1ron mentioned this issue Feb 12, 2024
Open
9 tasks
@Evengard Evengard linked a pull request Feb 12, 2024 that will close this issue
Open
9 tasks
@chilagrow
Copy link
Contributor

Do we have a list of commands that sends Stable API parameters? I found this page https://www.mongodb.com/docs/manual/reference/stable-api-changelog/#std-label-stable-api-changelog

@AlekSi AlekSi added the community Issues and PRs assigned to community members label Feb 15, 2024
@AlekSi
Copy link
Member

AlekSi commented Feb 15, 2024 •
edited

on @Evengard, blocked by @b1ron's FerretDB/dance#769

@AlekSi AlekSi self-assigned this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlekSi AlekSi

Labels
code/bug Some user-visible feature works incorrectly community Issues and PRs assigned to community members not ready Issues that are not ready to be worked on; PRs that should skip CI
Projects
Current Engineering
Status: Open
Milestone
No milestone
4 participants
@AlekSi @chilagrow @b1ron @ferretdb-bot