I believe every item should be waterlogged but needs something for contradicting items like lava bucket, magmacream and etc. Maybe not allowing it to be placed underwater or adding sizzling particles?

Looking good! I'll have a deeper look at this tonight

@JSBOfficial Hi, I've done some testing on my end and I would like if you could check the following:

• Upgrading from an old world with items that are already placed should not cause them to be waterlogged by default. Please check if the default value can be set to false
• I haven't looked into what waterlogged items do in the base game, are they only supposed to cover source blocks? On my testing, it looks like all the placeable items only get waterlogged in source blocks

@Ferdzz Hello, My understading about waterlogging is just it fixes the item's rendering underwater. So basically because every block in placeable items are custom shapes and placeable underwater I just added the fix to the source block which automatically fixes all the placeable items block rendering underwater.

Edit: I just tried now, I thought it's the same as before that you can put items underwater. As of now I don't have full understanding of how you implemented things so maybe I should just study your source code and try to find ways to implement it.

@JSBOfficial Ah I see, I didn't understand what waterlogged actually was for. Could you just check that the default value for when the world is updated to the latest version? Items shouldn't be waterlogged by default

Hello again, I tried studying it and tested some ways but it always sprouted some logical issues. I can't make the feature consistent and controlable per block but I don't see any world problems arising.

I've added a way to make it enabled per block just by adding some simple boolean condition but it will just enable the water rendering but it doesn't have the complete feature of IWaterLoggable cause if i add an implement of it, it will just allow every block to be placeable underwater. So with that the issues I get is that whenever I remove the bottom block while the Placeable Block above is waterlogged the water will not flow downwards. The other thing is because it's just the water rendering that is implemented then you can't add or remove water inside the Placeable Item Blocks. But will still check how chest behaves underwater to see if that is also the case.

@JSBOfficial Thank you, please let me know what you find when looking at the chest implementation

@Ferdzz what about this feature? Will it be merged?

@Eugen1344 not as it is now. This PR is 2 years old and full of conflicts. It would need to be reviewed for 1.16 too

Closing due to inactivity