[Firmware] Movements retry too many times

[gabrielburnworth]

FarmBot OS version

8.0.2

Behavior

Movements are currently attempted n^2 + n times, where n is the number of retries selected by the user. FarmBot OS attempts a movement n + 1 times, and every time FarmBot OS tries a movement, the firmware attempts the movement n times.

Expected

The movement retry mechanism should only be implemented in (one of) the firmware or FarmBot OS.

Relevant code

farmbot_os/farmbot_os/lib/farmbot_os/sys_calls.ex

Line 279 in 923f024

do_move_absolute(x, y, z, speed, retries - 1, [reason | errors])