Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate files in JAR #65

Closed
SlimeDog opened this issue Feb 14, 2024 · 7 comments · Fixed by #92
Closed

Duplicate files in JAR #65

SlimeDog opened this issue Feb 14, 2024 · 7 comments · Fixed by #92
Labels
bug Something isn't working

Comments

@SlimeDog
Copy link

FancyHolograms 2.0.5.53

Check the JAR file contents with unzip

$ unzip -t /tmp/FancyHolograms-2.0.5.53.jar
error: invalid zip file with overlapped components (possible zip bomb)
 To unzip the file anyway, rerun the command with UNZIP_DISABLE_ZIPBOMB_DETECTION=TRUE environmnent variable

The zip-bomb warning is caused by duplicated files in the JAR file. This is probably the result of the recent relocation of the library files during the build process.

  ./de/oliver/fancyholograms/libs/chatcolorhandler/messengers/Messenger.class
  ./de/oliver/fancyholograms/libs/chatcolorhandler/messengers/LegacyMessenger.class
  ./de/oliver/fancyholograms/libs/chatcolorhandler/messengers/AbstractMessenger.class
  ./de/oliver/fancyholograms/libs/chatcolorhandler/messengers/MiniMessageMessenger.class
  ./de/oliver/fancyholograms/libs/chatcolorhandler/ModernChatColorHandler.class
  ./de/oliver/fancyholograms/libs/chatcolorhandler/resolvers/Resolvers.class
  ./de/oliver/fancyholograms/libs/chatcolorhandler/resolvers/MiniPlaceholdersResolver.class
  ./de/oliver/fancyholograms/libs/chatcolorhandler/resolvers/Resolver.class
  ./de/oliver/fancyholograms/libs/chatcolorhandler/ChatColorHandler.class
  ./de/oliver/fancyholograms/libs/chatcolorhandler/parsers/Parsers.class
  ./de/oliver/fancyholograms/libs/chatcolorhandler/parsers/custom/LegacyCharParser.class
  ./de/oliver/fancyholograms/libs/chatcolorhandler/parsers/custom/MiniMessageParser.class
  ./de/oliver/fancyholograms/libs/chatcolorhandler/parsers/custom/PlaceholderAPIParser.class
  ./de/oliver/fancyholograms/libs/chatcolorhandler/parsers/custom/HexParser.class
  ./de/oliver/fancyholograms/libs/chatcolorhandler/parsers/custom/Parser.class

Clearly, the duplicate files should be removed.

The same issue exists in FancyHolograms 2.0.5.54.
@OliverSchlueter OliverSchlueter added the bug Something isn't working label Feb 21, 2024
@OakLoaf
Copy link
Contributor

OakLoaf commented May 16, 2024

Does this issue persist in 2.0.6.66?

@SlimeDog
Copy link
Author

Yes. Did you get a different result?

@OakLoaf
Copy link
Contributor

OakLoaf commented May 16, 2024

I am unsure how to test this personally, I am running on windows.

@SlimeDog
Copy link
Author

unzip should exist in a Windows development environment. In any event, did anything change in the build process that would resolve this issue? Here are the unzip results:

$ unzip -l /tmp/FancyHolograms-2.0.6.66.jar | grep chatcolorhandler | grep class | sort
     1140  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/resolvers/MiniPlaceholdersResolver.class
     1140  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/resolvers/MiniPlaceholdersResolver.class
    12847  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/ChatColorHandler.class
    12847  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/ChatColorHandler.class
     2032  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/messengers/Messenger.class
     2032  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/messengers/Messenger.class
     2457  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/parsers/custom/HexParser.class
     2457  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/parsers/custom/HexParser.class
      293  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/parsers/custom/Parser.class
      293  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/parsers/custom/Parser.class
     3225  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/messengers/LegacyMessenger.class
     3225  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/messengers/LegacyMessenger.class
     3478  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/parsers/custom/MiniMessageParser.class
     3478  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/parsers/custom/MiniMessageParser.class
     3561  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/parsers/Parsers.class
     3561  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/parsers/Parsers.class
     3967  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/messengers/AbstractMessenger.class
     3967  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/messengers/AbstractMessenger.class
     4071  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/resolvers/Resolvers.class
     4071  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/resolvers/Resolvers.class
     5344  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/ModernChatColorHandler.class
     5344  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/ModernChatColorHandler.class
     5355  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/messengers/MiniMessageMessenger.class
     5355  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/messengers/MiniMessageMessenger.class
      764  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/resolvers/Resolver.class
      764  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/resolvers/Resolver.class
      958  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/parsers/custom/LegacyCharParser.class
      958  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/parsers/custom/LegacyCharParser.class
      967  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/parsers/custom/PlaceholderAPIParser.class
      967  02-01-2024 00:02   de/oliver/fancyholograms/libs/chatcolorhandler/parsers/custom/PlaceholderAPIParser.class

@OakLoaf
Copy link
Contributor

OakLoaf commented May 16, 2024

I was unaware if anything had changed but wanted to verify before looking into it myself. Thanks for sending that information

OakLoaf added a commit to OakLoaf/FancyHolograms that referenced this issue May 16, 2024
@OakLoaf
Resolved duplicate files in jar FancyMcPlugins#65
a7928c2
@OakLoaf OakLoaf mentioned this issue May 16, 2024
Merged
OliverSchlueter pushed a commit that referenced this issue May 16, 2024
@OakLoaf
Fixed duplicate files in jar (#92)
496116d 
* Resolved duplicate files in jar #65

* Tested and resolved issue
@SlimeDog
Copy link
Author

AFK, so won't be able to test for a while.

@SlimeDog
Copy link
Author

Looks good in build 69. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed duplicate files in jar OakLoaf/FancyHolograms
3 participants
@SlimeDog @OakLoaf @OliverSchlueter