Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate ca.crt and openssl.cnf if not provided #672

Merged
merged 3 commits into from
May 19, 2024
Merged

generate ca.crt and openssl.cnf if not provided #672

merged 3 commits into from
May 19, 2024

Conversation

dudizimber
Copy link
Contributor

fix #670

@dudizimber dudizimber added the enhancement New feature or request label May 7, 2024
@dudizimber dudizimber requested a review from swilly22 May 7, 2024 10:24
@dudizimber dudizimber self-assigned this May 7, 2024
@dudizimber dudizimber linked an issue May 7, 2024 that may be closed by this pull request
Feature: Optionally provide TLS certs for docker image #670
Closed
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 7, 2024 •
edited

Warning

Rate Limit Exceeded

@dudizimber has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 54 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between ae2e936 and 7a57e04.

Walkthrough

The modifications in the gen-certs.sh script involve enhancing its functionality by incorporating checks for the presence of ca.crt and openssl.cnf before creating them. This ensures these vital files are only generated if they are not already present, facilitating the optional provisioning of TLS certificates for the docker image.

Changes

File Change Summary
.../gen-certs.sh Added checks for existence and conditional creation of ca.crt and openssl.cnf.

Assessment against linked issues

Objective Addressed Explanation
Feature: Optionally provide TLS certs for docker image (#670) ✅

Poem

🐇 Hop, hop, hooray! A script so bright,
📜 Checks if files are just right.
No more overwrite, no needless fright,
With certs so secure, we sleep well at night.
CodeRabbit leaps, the code takes flight!
🌟🚀🌙

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 7, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 3f95149 and 3ba25e8.
Files selected for processing (1)
  • build/docker/gen-certs.sh (1 hunks)
Additional Context Used
ShellCheck (5)
build/docker/gen-certs.sh (5)

[info] 19-19: Double quote to prevent globbing and word splitting.

[info] 19-19: Double quote to prevent globbing and word splitting.

[info] 23-23: Double quote to prevent globbing and word splitting.

[info] 31-31: Double quote to prevent globbing and word splitting.

[info] 32-32: Double quote to prevent globbing and word splitting.

build/docker/gen-certs.sh Outdated Show resolved Hide resolved
build/docker/gen-certs.sh Outdated Show resolved Hide resolved
coderabbitai[bot]
coderabbitai bot reviewed May 7, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 3ba25e8 and ae2e936.
Files selected for processing (1)
  • build/docker/gen-certs.sh (1 hunks)
Additional Context Used
ShellCheck (5)
build/docker/gen-certs.sh (5)

[info] 19-19: Double quote to prevent globbing and word splitting.

[info] 19-19: Double quote to prevent globbing and word splitting.

[info] 23-23: Double quote to prevent globbing and word splitting.

[info] 31-31: Double quote to prevent globbing and word splitting.

[info] 32-32: Double quote to prevent globbing and word splitting.

Additional comments not posted (2)
build/docker/gen-certs.sh (2)

36-37: Ensure the existence of ca.crt before generating it.

This change correctly adds a conditional check to ensure ca.crt is only generated if it does not already exist, which is a good practice to avoid unnecessary overwrites.

44-44: Ensure the existence of openssl.cnf before creating it.

The addition of a conditional check before creating openssl.cnf is a prudent measure to prevent overwriting an existing configuration, which could potentially disrupt existing setups.

@AviAvni AviAvni merged commit b864f26 into master May 19, 2024
14 checks passed
@AviAvni AviAvni deleted the 670-feature-optionally-provide-tls-certs-for-docker-image branch May 19, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai left review comments

@AviAvni AviAvni AviAvni approved these changes

@swilly22 swilly22 Awaiting requested review from swilly22

Assignees

@dudizimber dudizimber

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Optionally provide TLS certs for docker image
2 participants
@dudizimber @AviAvni