Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky theads throughout the UI (e.g. on channel inputs, outputs, gpio ins etc) #1826

Open
OnlineDynamic opened this issue Mar 25, 2024 · 5 comments
Assignees

Comments

@OnlineDynamic
Copy link
Collaborator

This is a placeholder for a PR request that I have almost finished which will make all the table theads sticky (on the screens where it makes sense) to keep column headings on display when the page scrolls

@cpinkham Would it be possible to get rights to be able to assign issues to myself as I help with contributions? Just so I can start to attack some of the already open items and you would know I'm looking at it so we don't duplicate effort

@darylc
Copy link
Contributor

darylc commented Mar 26, 2024

@OnlineDynamic I can't do anything re permissions but I can assign things to you if you comment in the issues you want assigned

@patdelaney
Copy link
Contributor

I think I understand the enhancement, once completed, please list the places where the enhancement is so that we can test it. Thanks Pat

@OnlineDynamic
Copy link
Collaborator Author

Will do.. simply it changes the scroll behaviour on the tables so the headings stay at the top, so from looking like:

image

to:

image

@cpinkham
Copy link
Contributor

cpinkham commented Apr 5, 2024

I added you as an external collaborator for now with triage privs on the fpp repository. I think that should give you the ability to assign tickets to yourself.

@OnlineDynamic
Copy link
Collaborator Author

Have raised PR #1829

@patdelaney places to check:

adds sticky table headers to:

backup.php (2 tables on same page)
index.php and its modal schedule preview
proxies.php
commandPresets.php
scheduler.php (main page and modal preview)
channelinputs.php
channeloutputs.php (all tabs with table/header content)
outputprocessors.php
gpio.php
pixeloverlaymodels.php ( 2 tables)

It also introduces a new text search/filter on the script broswers page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants