MustWalk and the animation-less scuba suit cause a walking animation lock.

[Regalis11]

Discussed in #13846

^{Originally posted by HakureiReimu18 April 26, 2024}

Disclaimers

• I have searched the issue tracker to check if the issue has already been reported.
• My issue happened while using mods.

What happened?

This is a bug related to MustWalk. In the game, I wrote a new Affliction that applies the MustWalk effect using AbilityFlag, which worked fine in previous versions. However, after the recent character skeleton animation update, if this Affliction is repeatedly applied, and then the character wears a scuba suit that does not change the character's animation, and waits for the effect to wear off before applying it again, the character's walking animation will still be the default Vanilla scuba suit walking animation, regardless of whether the scuba suit is worn or not. This is the link to my mod's Steam Workshop page:https://steamcommunity.com/sharedfiles/filedetails/?id=2941124988

Reproduction steps

1. In my mod, there is an affliction associated with a character's clothing. Wearing it applies several afflictions, one of which restricts the character to walking only, utilizing MustWalk. In my mod, there are two pieces of equipment and a new skill level that, when their conditions are met, can remove this debuff.
2. I opened the submarine editor and prearranged items in it, then started testing. First, I had the character wear the "Patchouli's Outfit+" which grants an additional talent and continuously applies "The_Still_Library" affliction.
3. I entered the command "setskill Touhou_Magic max" in the F3 console to maximize the skill level of the new skill added by your mod. Then, I helped you equip the "Magic_Pouch" and "Magic_Veil" so that you can consistently obtain the "Touhou_Magic_Boost" effect. When this effect reaches its maximum value, your character will become immune to the affliction called "MustWalk," allowing them to regain their running ability.
4. The problem lies here. When the character becomes immune to "MustWalk," their animation is normal. However, if I remove the "Magic_Pouch" and the character loses the immunity to "MustWalk," and then apply the "MustWalk" effect again, the character's walking animation will change to the animation used when wearing a diving suit. This also happens when I remove the "Magic_Veil." Regardless of what actions I take, the walking animation remains the same, and only the walking animation changes in this manner.

Because I wrote the color file, its actual name should be "‖color:120,75,100,255‖Patchouli's Outfit+‖color:end‖".This clothing is located in "Items/Clothes/Patchouli_gear.xml".

In addition, please let me explain the Affliction related to MustWalk: When wearing "‖color:120,75,100,255‖Patchouli's Outfit+‖color:end‖", it will continue to give the Affliction "The Great Unmoving Library", with the id "The_Still_Library", which can be found in line 393 of the "Touhou_Character_Afflictions.xml" file. It will give a new affliction, with the id "The_Still_Library_Walk_NotInWater", located in line 424 of the "Touhou_Character_Afflictions.xml". This Affliction uses "", which is the method I use to make the character MustWalk. I hope these additional details can provide enough information to help you find the bug.

QQ2024426-13338_20240426_19205741.mp4

Bug prevalence

Happens every time I play

Single player or multiplayer?

Happens in both single player and multiplayer

-

No response

Version

v1.4.4.1 (Blood in the Water Update)

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

No response

[Regalis11]

Even though the repro steps seem convoluted and maybe mod-specific, I think the issue here boils down to the game choosing an incorrect animation in a case where a talent forces the character to walk, which might occur in other situations too. So seems something worth investigating imo.