[Modding] Vanilla hallways still generate in modded outposts

[ubertpendragon]

Disclaimers

• I have searched the issue tracker to check if the issue has already been reported.
• My issue happened while using mods.

What happened?

Vanilla hallways will force themselves on modded outposts, no matter if you specify allowed location types.

Here the hallway has allowedlocationtypes defined to the intended locations:

I assume this is the relevant part of the code that says modules configured with locations/flags should take priority:

Barotrauma/Barotrauma/BarotraumaShared/SharedSource/Map/Outposts/OutpostGenerator.cs

Line 882 in 3b722fa

//try to search for modules made specifically for this location type first

Barotrauma/Barotrauma/BarotraumaShared/SharedSource/Map/Outposts/OutpostGenerator.cs

Line 1212 in 3b722fa

Identifier moduleFlag = (isHorizontal ? "hallwayhorizontal" : "hallwayvertical").ToIdentifier();

We had a LENGTHY discussion on the modding discord about the workarounds to prevent this (reference to #7281) and it's either bugged or unintuitive

Possible Solutions:

Set all vanilla hallways to 0 commonness (currently 10). In theory they should still generate if there are no other options, but this should prevent them from generating at custom locations if custom hallways are set up.

I've tested this by modifying vanilla files and got no error. Rolled a bunch of vanilla and modded outposts, no issues there so it should be the simplest solution

Version

Unstable

[ubertpendragon]

The mod:

#DELocalHuskModIntegrated.zip

1 Go to leveleditor
2 Generate coldcavernsoutpost + miningoutpost a bunch of times
3 Increase hallway length if needed

[Regalis11]

Addressed in https://github.com/FakeFishGames/Barotrauma-development/commit/088e4327dd58943c90a39b8f6bdf92e42d9a82d8

[Jasontti]

Tested in: https://github.com/FakeFishGames/Barotrauma-development/pull/4996/commits/27da37ba7a2caec51865da8e854147f590aafb2f

Tested in vanilla and with DE
Vanilla hallways did not generate on lair outposts anymore

No issues found
Closing ticket