Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Expiring and Postponed RBACDefinitions #204

Open
terrykong opened this issue Feb 19, 2021 · 2 comments
Open

[Feature Request] Expiring and Postponed RBACDefinitions #204

terrykong opened this issue Feb 19, 2021 · 2 comments
Labels
enhancement Adding additional functionality or improvements help wanted Extra attention is needed pinned Prevents stalebot from removing priority: could Future work depending on bandwidth and availability

Comments

@terrykong
Copy link

terrykong commented Feb 19, 2021

Hi team,

This is a really awesome tool and it's helped us reduce a lot of repeated binding specs.

I was wondering if it would be possible to add a way to specify for how long a RBACDefinition is valid for, and additionally, a "start date" to specify when the RBACDefinition will become valid. For example, it would be nice if we could do the following (extending the example on the README):

apiVersion: rbacmanager.reactiveops.io/v1beta1
kind: RBACDefinition
metadata:
  name: dev-access
rbacBindings:
  - name: dev-team
    subjects:
      - kind: Group
        name: dev-team
    roleBindings:
      - clusterRole: edit
        namespaceSelector:
          matchLabels:
            team: dev
    # If startTime is omitted, then it is valid immediately
    startTime: "2020-09-15T00:17:10Z"
    # If endTime is omitted, then it is valid indefinitely
    endTime: "2021-09-15T00:17:10Z"

Some use cases I had in mind were:

  1. Sometimes I want to give temporary access, and for that I could use some kind of endTime field
  2. Perhaps I have a new employee that I know will need permissions at some point, I could specify a startTime so that I could apply the RBACDefinition now, but it's effect won't take place until later. Another example here is: I have an intern for which I know the exact time they start and end, so I could set up their roles to have a start and expiry date.
@sudermanjr
Copy link
Member

This would be a really cool feature. I feel like it might be a significant change, but a very very cool feature.

@sudermanjr sudermanjr added the enhancement Adding additional functionality or improvements label Feb 19, 2021
@stale
Copy link

stale bot commented Apr 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Marked as stale by stalebot label Apr 13, 2021
@stale stale bot closed this as completed Apr 26, 2021
@sudermanjr sudermanjr added priority: could Future work depending on bandwidth and availability and removed stale Marked as stale by stalebot labels Oct 27, 2021
@sudermanjr sudermanjr reopened this Oct 27, 2021
@lucasreed lucasreed added the pinned Prevents stalebot from removing label Jan 12, 2022
@sudermanjr sudermanjr added the help wanted Extra attention is needed label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding additional functionality or improvements help wanted Extra attention is needed pinned Prevents stalebot from removing priority: could Future work depending on bandwidth and availability
Projects
Status: No status
Development

No branches or pull requests

3 participants