Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favourite is not working #203

Closed
wesleycoder opened this issue May 10, 2020 · 6 comments
Closed

Favourite is not working #203

wesleycoder opened this issue May 10, 2020 · 6 comments

Comments

@wesleycoder
Copy link

The button for favoriting is disabled.
Tried favoriting this blueprint on chrome:
https://www.factorio.school/view/-M2ZjQ7ClF06M3fvp684

I'm available for helping debug this if needed.

@FactorioBlueprints
Copy link
Owner

FactorioBlueprints commented May 11, 2020 via email

@wesleycoder
Copy link
Author

Oh sure!
May I keep this issue open to track the progress on this?

@FactorioBlueprints
Copy link
Owner

FactorioBlueprints commented May 15, 2020 via email

@leonard84
Copy link

Factorio.school is a read-only replica of factorioprints.com for now

So what is the status of both sites?
For example I can't find https://www.factorio.school/view/-LbgGSB0UaoCww6EOycF on https://factorioprints.com/ via the search. However, if I manually construct the url I can see and favorite it https://factorioprints.com/view/-LbgGSB0UaoCww6EOycF

It seems that the search is better on https://www.factorio.school, but the Next Page button doesn't seem to work.

@wesleycoder
Copy link
Author

As I understand on factorioprints the search feature searches only on the current page, but on factorio.school the search is throughout the entire database.

@wesleycoder
Copy link
Author

This is not relevant for me anymore and since there was no activity for a long time I'll be closing this PR so it clears out of the pile.
If needed feel free to open another PR and mention this to keep track of the history if relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants