Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector3f is in client.util.math #978

Closed
Juuxel opened this issue Nov 23, 2019 · 6 comments · Fixed by #1879
Closed

Vector3f is in client.util.math #978

Juuxel opened this issue Nov 23, 2019 · 6 comments · Fixed by #1879
Assignees
Labels
bug Fixes or discusses a bug within the mappings discussion

Comments

@Juuxel
Copy link
Member

Juuxel commented Nov 23, 2019

It's not client-only (as of 1.15-pre1).

@liach liach added the bug Fixes or discusses a bug within the mappings label Nov 26, 2019
@liach
Copy link
Contributor

liach commented Nov 26, 2019

Hmm, these Vector stuff etc. are featured by their mutable fields and overwhelmingly client usage compared to their util.math counterparts. Interesting thing to look into.

@Runemoro
Copy link
Contributor

The Vec and Vector naming is also very weird. It doesn't make sense to name two classes the same but with one name abbreviated. What's the important difference between Vector3d and Vec3d (why doesn't Mojang use a single class?).

@liach
Copy link
Contributor

liach commented Nov 26, 2019

we have Vec for immutable types and Vector for mutable types.

@Runemoro
Copy link
Contributor

Then I think Vector Should be MutableVec.

@liach
Copy link
Contributor

liach commented May 15, 2020

@Yanis48 Actually I am not very sure on handling this yet; should we rename this to Vector3f to distinguish from the immutable vec3d in minecraft util math package and move to minecraft util math, or?

@YanisBft
Copy link
Contributor

I think we should rename it to Vec3f, and move it to nm.util.math

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes or discusses a bug within the mappings discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants