Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registry.STRUCTURE_PIECE -> Registry.STRUCTURE_PIECE_TYPE #916

Closed
Draylar opened this issue Oct 20, 2019 · 6 comments
Closed

Registry.STRUCTURE_PIECE -> Registry.STRUCTURE_PIECE_TYPE #916

Draylar opened this issue Oct 20, 2019 · 6 comments
Labels
enhancement refactor A PR that renames existing names. vote A vote on a name refactor

Comments

@Draylar
Copy link
Contributor

Draylar commented Oct 20, 2019

Registry.STRUCTURE_PIECE wants a StructurePieceType, which is a factory for creating StructurePieces. The name should be changed to STRUCTURE_PIECE_TYPE to reflect this (as is the case with the BlockEntityType/EntityType registries).
@JamiesWhiteShirt
Copy link
Contributor

What is the name of the registry in the registry of registries? Probably structure_piece, in which case the name should remain.

@Draylar
Copy link
Contributor Author

Draylar commented Oct 20, 2019 •
edited

Is that because changing to STRUCTURE_PIECE_TYPE would require changing structure_piece to structure_piece_type, which would mess things up?
edit: and yes, it is structure_piece in the registry

@liach
Copy link
Contributor

liach commented Oct 21, 2019

I don't think the names in registry are auto. So yes, we can do this change. Will mark this for a vote.

@liach liach added enhancement refactor A PR that renames existing names. vote A vote on a name refactor labels Oct 21, 2019
@LemmaEOF
Copy link

Well, structure_piece in the registry registry are hardcoded strings from mojang, iirc. I say we keep to Registry.STRUCTURE_PIECE since that's the standard for anything registered.

@liach
Copy link
Contributor

liach commented Oct 22, 2019

fyi we already named the thing in the registry structure piece type.

@valoeghese
Copy link
Contributor

The result of this vote seems conclusive

@Runemoro Runemoro closed this as completed Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement refactor A PR that renames existing names. vote A vote on a name refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Runemoro @JamiesWhiteShirt @LemmaEOF @liach @Draylar @valoeghese