Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init or initialize? #618

Closed
Runemoro opened this issue Apr 14, 2019 · 8 comments
Closed

init or initialize? #618

Runemoro opened this issue Apr 14, 2019 · 8 comments

Comments

@Runemoro
Copy link
Contributor

There are many init methods and many initialize methods. We should pick one for consistency.
@liach
Copy link
Contributor

liach commented Apr 14, 2019

init.

@Runemoro
Copy link
Contributor Author

initialize.

Vote for either me or liach.

@asiekierka
Copy link
Contributor

Mojang uses init, and for the 1.14 cycle we're sticking with deobf Mojang names, so... I think the answer is clear-cut, at least for now.

@Prospector
Copy link
Contributor

close?

@Runemoro
Copy link
Contributor Author

Was this fixed yet?

@Prospector
Copy link
Contributor

oh maybe not but it sounds like we're going with init

@valoeghese
Copy link
Contributor

Is this fixed yet 🤔

@Runemoro
Copy link
Contributor Author

Runemoro commented Aug 1, 2019

Yes, it seems like initialize is gone.

@Runemoro Runemoro closed this as completed Aug 1, 2019
@liach liach mentioned this issue Apr 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@asiekierka @Runemoro @Prospector @liach @valoeghese