Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringItem -> PlaceableItem #525

Closed
LemmaEOF opened this issue Mar 14, 2019 · 3 comments
Closed

StringItem -> PlaceableItem #525

LemmaEOF opened this issue Mar 14, 2019 · 3 comments

Comments

@LemmaEOF
Copy link

StringItem is now a generic class for any item that has a separate Block as a placeable form. This includes string as well as all seeds, carrots, potatoes, sweet berries, cocoa beans, nether wart, and redstone dust. Given this, I think the class should be renamed to reflect its new usage.
@Prospector
Copy link
Contributor

It's not a placeable item, it's an ItemBlock with a different translation key from the block.

@Prospector
Copy link
Contributor

perhaps DistinctBlockItem

@Daomephsta
Copy link

How about AliasedBlockItem?

Pyrofab added a commit to Pyrofab/yarn that referenced this issue Apr 22, 2019
@Pyrofab
Rename StringItem, fixes FabricMC#525
70955c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Prospector @LemmaEOF @Daomephsta