Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockPos -> Position #490

Closed
ChloeDawn opened this issue Feb 20, 2019 · 6 comments
Closed

BlockPos -> Position #490

ChloeDawn opened this issue Feb 20, 2019 · 6 comments

Comments

@ChloeDawn
Copy link
Contributor

Feedback ticket for a controversial proposal. Reasons for and against this are much appreciated. "BlockPos is the known Mojang name" is not a valid argument in my opinion. Many classes have known Mojang names that are not used. I argue that BlockPos is actively used for more than just blocks. Position is a more generic representation of an int-based position vector.

@SquidDev
Copy link
Contributor

The "nice" thing about BlockPos is that it indicates it's clamped to the coordinate grid. Position feels more vague (more suited for Vec3f), and doesn't really take into account the coordinate-grid specific methods that you have (such as offsetting by a direction).

@asiekierka
Copy link
Contributor

Position is more suited for floating-point vectors.

@LemmaEOF
Copy link

Yeah, I'm gonna say that if we change BlockPos we still need to emphasize that it's an integer.

@ChloeDawn
Copy link
Contributor Author

The feedback is appreciated and I do agree that this name would be more fit to a floating point vector.

@liach
Copy link
Contributor

liach commented Feb 20, 2019

If you feel too bored, you can call it IntegerLattice instead

@Runemoro
Copy link
Contributor

you can call it IntegerLattice instead

The lattice is the set of all points. It would have to be IntegerLatticePoint/IntegerLatticePosition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants