New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CommandBlockBlockEntity -> CommandBlockEntity #402
Comments
It's a |
But on that logic, the |
You got a point ^^ |
Fair. |
Personally I think there should be a double Block suffix. As it's a (Note Block) Block, not a (Note) Block |
I think it should. |
Also relevant here are the |
I'm for CommandBlockBlock |
Isn't the suffix intent to make it clear the type of the class? CommandBlock already contains, block, because it's a suffix created from mojang to denote, commands of type block. It isn't needed the BlockBlock here. |
Except block isn't the suffix; the entire base class is. In this case, the suffix of any subclass of BlockEntity would be BlockEntity - as with every other base class in the current mappings - and the prefix of every subclass of BlockEntity is the entire class name of its block, including the prefix of that class name, thus the prefix is CommandBlock and the suffix is BlockEntity. |
I don't think it is, because of |
For one, the block class is called
CommandBlock
, notCommandBlockBlock
, and it also makes it a lot less clunky of a name. It seems like this might be an artifact from the prefix -> suffix move.The text was updated successfully, but these errors were encountered: