Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommandBlockBlockEntity -> CommandBlockEntity #402

Open
LemmaEOF opened this issue Jan 16, 2019 · 11 comments
Open

CommandBlockBlockEntity -> CommandBlockEntity #402

LemmaEOF opened this issue Jan 16, 2019 · 11 comments

Comments

@LemmaEOF
Copy link

For one, the block class is called CommandBlock, not CommandBlockBlock, and it also makes it a lot less clunky of a name. It seems like this might be an artifact from the prefix -> suffix move.

@MisterPeModder
Copy link
Contributor

It's a CommandBlock BlockEntity not a CommandBlockBlock Entity

@LemmaEOF
Copy link
Author

But on that logic, the CommandBlock class should be called CommandBlockBlock.

@MisterPeModder
Copy link
Contributor

You got a point ^^

@asiekierka
Copy link
Contributor

Fair.

@Prospector
Copy link
Contributor

Personally I think there should be a double Block suffix. As it's a (Note Block) Block, not a (Note) Block

@Runemoro
Copy link
Contributor

But on that logic, the CommandBlock class should be called CommandBlockBlock.

I think it should.

@Gegy
Copy link
Contributor

Gegy commented Jan 25, 2019

Also relevant here are the grass and grass_block blocks. Not sure how those are currently named, but probably should be considered within this context

@asiekierka
Copy link
Contributor

I'm for CommandBlockBlock

@EduardoRFS
Copy link

EduardoRFS commented Jan 28, 2019

Isn't the suffix intent to make it clear the type of the class? CommandBlock already contains, block, because it's a suffix created from mojang to denote, commands of type block. It isn't needed the BlockBlock here.

@RedstoneParadox
Copy link
Contributor

Except block isn't the suffix; the entire base class is. In this case, the suffix of any subclass of BlockEntity would be BlockEntity - as with every other base class in the current mappings - and the prefix of every subclass of BlockEntity is the entire class name of its block, including the prefix of that class name, thus the prefix is CommandBlock and the suffix is BlockEntity.
Removing one of the Blocks can be read as prefix CommandBlock with suffix Entity - implying it's a subclass of Entity at first glance - prefix Command with the suffix BlockEntity - implying that it's the BlockEntity of a block called Command and not CommandBlock at first glance - or simply as a shortened form of CommandBlockBlockEntity, thus introducing ambiguity.
That being said, most people should know by now that CommandBlocks have BlockEntities and not normal Entities and that CommandBlock starts with Command. However, the current way is consistent with the rest of the mappings, and consistency makes things easier, even if it doesn't roll off the tongue quite as easily.

@LemmaEOF
Copy link
Author

the current way is consistent with the rest of the mappings

I don't think it is, because of CommandBlock not being CommandBlockBlock. Your point on ambiguity is good, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants