New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MathHelper -> Mth #249
Comments
definitely confusing. when it was first brought up I thought it was a joke... but hey. it's shorter so whatever |
|
|
Math 2: Electric Boogaloo As long as it'll have a JavaDoc saying that it's a Math Helper, and it's documented later on, then yes. |
Mth doesn't match the naming conventions and imo is not sufficiently descriptive. I'd rather go with something like McMath to also imply that it's kind of like math, but not very accurate or universal since it sometimes uses low precision approximations. |
( |
|
|
|
|
Maths seems a little close to Math, which is already a Class in the Java libraries, so people might get confused. Since its purpose seems to be related to in-world math, maybe something like BlockMath could work. |
Some methods like square root and partialtick and locatiom is used for rendering. |
I prefer |
Agreed. |
Mth is good IMO. Good to use the Mojang names, especially on classes like this that aren't used too much |
I think we should get a decision made on this soon |
I'll quote @tterrag on this:
There is currently no class called Math2 in a default loom workspace. I think it's a very good fit. |
Guava has a lot of utility classes that have name clashes with Java Library classes. While older clashes are named like |
I like both of them but surely MathHelper is intuitive. |
If I have to say I would like to propose |
I'll point out this issue has 12 upvotes and only 4 down. Perhaps a PR should be considered. |
Since you commented that, it got 4 more downvotes and only one upvote. So I'd call this controversial at best. I don't think we should sacrifice a good meaningful name to a bad Mojang Name. |
Advantages:
Disadvantages:
The text was updated successfully, but these errors were encountered: