Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MathHelper -> Mth #249

Closed
asiekierka opened this issue Dec 10, 2018 · 23 comments
Closed

MathHelper -> Mth #249

asiekierka opened this issue Dec 10, 2018 · 23 comments

Comments

@asiekierka
Copy link
Contributor

Advantages:

  • Mojang uses it.
  • It rolls off the keyboard better.

Disadvantages:

  • A bit confusing?
@Prospector
Copy link
Contributor

definitely confusing. when it was first brought up I thought it was a joke... but hey. it's shorter so whatever

@quat1024
Copy link
Contributor

Math2?

@kashike
Copy link
Contributor

kashike commented Dec 10, 2018

Math2 goes along the lines of Guava's Collections2.

@Lordmau5
Copy link

Math2?

Math 2: Electric Boogaloo


As long as it'll have a JavaDoc saying that it's a Math Helper, and it's documented later on, then yes.

@sfPlayer1
Copy link
Collaborator

Mth doesn't match the naming conventions and imo is not sufficiently descriptive.

I'd rather go with something like McMath to also imply that it's kind of like math, but not very accurate or universal since it sometimes uses low precision approximations.

@unascribed
Copy link
Contributor

FastMath?

(Mth reads as "meth" to me)

@asiekierka
Copy link
Contributor Author

I'm not sure if implying Mojang's math is faster is good idea

@unascribed
Copy link
Contributor

MathExceptSlightlyWorseButMaybeItsFasterIDunno

@Prospector
Copy link
Contributor

meanwhile implying their math is like meth may not be an issue

@liach
Copy link
Contributor

liach commented Dec 11, 2018

Maths. In Great Britain and Australia, mathematics is shortened as "Maths" instead of "Math".

@RedstoneParadox
Copy link
Contributor

But the USA doesn't, so we don't either

Maths seems a little close to Math, which is already a Class in the Java libraries, so people might get confused. Since its purpose seems to be related to in-world math, maybe something like BlockMath could work.

@liach
Copy link
Contributor

liach commented Dec 11, 2018

Some methods like square root and partialtick and locatiom is used for rendering.

@Vexatos
Copy link

Vexatos commented Dec 11, 2018

I prefer MathHelper over an unpronounceable classname.

@shadowfacts
Copy link
Contributor

Agreed. MathHelper is fine, and it's used rarely enough by modders that typing it out is not an issue.

@Prospector
Copy link
Contributor

Mth is good IMO. Good to use the Mojang names, especially on classes like this that aren't used too much

@Prospector
Copy link
Contributor

I think we should get a decision made on this soon

@JamiesWhiteShirt
Copy link
Contributor

I'll quote @tterrag on this:

so the two sides of the war seem to be expressiveness vs conciseness. So isn't the middle ground Math2?

It's perfectly expressive
Easy to autocomplete
Matches an existing pattern

There is currently no class called Math2 in a default loom workspace. I think it's a very good fit.

@liach
Copy link
Contributor

liach commented Dec 23, 2018

Guava has a lot of utility classes that have name clashes with Java Library classes. While older clashes are named like Collections2, the newer classes are prefixed with More instead, such as Objects -> MoreObjects. As a result, I still suggest MoreMath or McMath coined by player.

@shedaniel
Copy link
Contributor

I like both of them but surely MathHelper is intuitive.

@3TUSK
Copy link
Contributor

3TUSK commented Feb 22, 2019

If I have to say I would like to propose MathTool or MathTools. Sure Mth rolls off keyboard faster, but from a non-native speaker's POV... I am not sure if this doesn't create a mess.
Personally I am fine with Mth.

@Prospector
Copy link
Contributor

I'll point out this issue has 12 upvotes and only 4 down. Perhaps a PR should be considered.

@NeunEinser
Copy link
Contributor

Since you commented that, it got 4 more downvotes and only one upvote. So I'd call this controversial at best.

I don't think we should sacrifice a good meaningful name to a bad Mojang Name.

@liach
Copy link
Contributor

liach commented Oct 9, 2019

Given the current result 12 👍 versus 13 👎, will keep the current MathHelper name.
image

Comment if there is more concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests