Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HitResult -> ??? #245

Closed
ChloeDawn opened this issue Dec 6, 2018 · 1 comment
Closed

HitResult -> ??? #245

ChloeDawn opened this issue Dec 6, 2018 · 1 comment

Comments

@ChloeDawn
Copy link
Contributor

I feel this should be changed from the Mojang name, as it is misleading when taking into consideration the hit type can be a MISS. A result of a hit that is a MISS makes no sense from a logical perspective. This class would be better just representing the data it contains, rather than what it tried to achieve.

A possible name could be RaytraceContext, but I'll leave this up for proper discussion.

@asiekierka
Copy link
Contributor

I think the lack of a result with a hit attempt is a perfectly fine result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants