Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improper names from #200 prefix -> suffix move #205

Closed
3 of 4 tasks
Prospector opened this issue Nov 27, 2018 · 8 comments
Closed
3 of 4 tasks

Improper names from #200 prefix -> suffix move #205

Prospector opened this issue Nov 27, 2018 · 8 comments

Comments

@Prospector
Copy link
Contributor

Prospector commented Nov 27, 2018 •
edited by asiekierka

  • ListMultiWidget should be MultiListWidget (though now that I think about it... I don't know what is Multi about the list at all? Either way, ListMultiWidget is not right)
  • SkeletonBaseEntity should be AbstractSkeletonEntity
  • EntityCat should be CatEntity
  • Entity datafixers...there's a few https://i.imgur.com/qsdgdZm.png
@LemmaEOF
Copy link

LemmaEOF commented Nov 27, 2018 •
edited by asiekierka

  • BlockState was incorrectly changed to StateBlock

@jamierocks
Copy link
Contributor

As far as data fixers are concerned, I think they are fine.

  1. They are following already specified names
  2. In the absence of entity, etc packages, the prefix is justified

@Prospector
Copy link
Contributor Author

hmm maybe. Not sure I agree though. I'd suggest make an entity package then.

@asiekierka
Copy link
Contributor

I don't agree that the prefix is justified and am siding with @ProfessorProspector on this.

@liach
Copy link
Contributor

liach commented Nov 28, 2018

PlayerServerEntity -> ServerPlayerEntity

@asiekierka
Copy link
Contributor

Actually, I agree the prefix is justified. Looking into it myself now.

@SquidDev
Copy link
Contributor

SquidDev commented Nov 28, 2018 •
edited

Possibly also

  • FactoryBlockEntity->BlockEntityFactory`?

@SquidDev
Copy link
Contributor

SquidDev commented Nov 28, 2018 •
edited

A few more:

  • PlacementContextItem -> ItemPlacementContext
  • net.minecraft.server.command.OutputCommand -> CommandOutput
  • net.minecraft.server.command.SourceCommand -> CommandSource
  • EntityProviderBlock -> BlockEntityProvider. Maybe BlockEntityProviderBlock, but probably not?

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@asiekierka @SquidDev @jamierocks @Prospector @LemmaEOF @liach