New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBlockState parameters: state or block? #149
Comments
And |
Similar with |
Why not unambiguous parameters like |
@mezz Because they're long and don't really add anything. Ideally a parameter shouldn't be named after the type but its use in the code. And in use, I often think of said parameter as "the 'item' the method is operating on". It might be confusing because we have the |
From what has been discussed in irc various times, it sounds like are going with |
Yes. |
In many places,
IBlockState
s are used in places whereBlock
would have been in the past. I almost want to call parameters of that typeblock
since it makes more sense to me. What do you think?Additionally, this opens up the question of whether
IBlockState
should simply be renamed toIBlock
, andBlock
toBlockType
, or something? Though maybe that's a bit too early - should wait for what Mojang is going to do to Blocks, at the very least..?The text was updated successfully, but these errors were encountered: