Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"chunk section" -> "section" #1142

Closed
Runemoro opened this issue Feb 28, 2020 · 6 comments
Closed

"chunk section" -> "section" #1142

Runemoro opened this issue Feb 28, 2020 · 6 comments
Labels
refactor A PR that renames existing names. vote A vote on a name refactor

Comments

@Runemoro
Copy link
Contributor

Right now we have a mix of both "chunk section" and just "section" to refer to 16x16x16 regions. I think we should shorten this to "section" everywhere, since "section" is a common enough term to refer to them. A few vanilla strings also refer to them as just "sections".

@Runemoro Runemoro added refactor A PR that renames existing names. vote A vote on a name refactor labels Feb 28, 2020
@Earthcomputer
Copy link
Contributor

I see it as the phrase "chunk section" which means 16x16x16 regions, and "section" on its own as meaningless, and too vague, if you don't already happen to know what it means. "section" is arguably fine in parameter names where "chunk" can be inferred from other context.

@liach
Copy link
Contributor

liach commented Feb 22, 2021

Now that mojang has tweaked height and sections may become the basic unit of loading (this is already the case for entities). Will we reconsider naming this section?

@liach
Copy link
Contributor

liach commented Mar 28, 2021

After thinking, I agree that we should treat this thing as "chunk section". We do have "item stack" and frequently call it stack, yet "stack" on its own does not mean an item stack. Similar logic should go here.

This has been open for more than 1 year. The vote as of this comment is 6×:-1:. If there is no extra comments or votes in 24 hours, the current vote will be taken as the result.

@Earthcomputer
Copy link
Contributor

If we are to rename it, I'd rename it to subchunk, which is widely used in the niche tech community and I think is a better name than chunk section, but chunk section is the more widely accepted name for it.

@liach
Copy link
Contributor

liach commented Mar 28, 2021

Seeing that mojang is already using them a lot since the expansion of height. I guess they may have a colloquial name for it one day in the release notes, and we can go and see by that point. (though mojang colloquial names aren't always very good either, like "chat component" is just... you know)

@liach
Copy link
Contributor

liach commented Apr 2, 2021

So the vote is clear. We won't name this section until mojang does some big mechanism changes, in case we shall revisit again.

@liach liach closed this as completed Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A PR that renames existing names. vote A vote on a name refactor
Projects
None yet
Development

No branches or pull requests

3 participants