New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numpy should be limited to 1.23.5 #12
Comments
The conda forge package should be updated as well |
updated to which version? @julian-belina |
Numpy should be limitted to numpy<=1.23.5. This sould also be included in the coda-forge package. |
Issue with Numpy<1.4 is related to the dependency "Geokit". We will update the Glaes requirements to reflect this for now, once Geokit has been updated can remove this limitation. |
We will leave the issue open to inform as long as numpy is limited to <1.24 and remove it afterwards. Could you paste the respective geokit test error into a geokit github issue as well @julian-belina ? |
An issue has been opened on the geokit repository: |
The numpy version in environment.yml should be limited to numpy<=1.23.5. With numpy 1.24 i get the following error when running the tests:
----------------------------- Captured stderr call -----------------------------
pj_obj_create: Open of /home/runner/miniconda3/envs/test_env/share/proj failed
________________________ test_ExclusionCalculator_save _________________________
glaes/glaes/test/test_ExclusionCalculator.py:60:
glaes/glaes/core/ExclusionCalculator.py:238: in init
s.maskPixels = s.region.mask.sum()
../../../miniconda3/envs/test_env/lib/python3.8/site-packages/geokit/core/regionmask.py:470: in mask
self.buildMask()
../../../miniconda3/envs/test_env/lib/python3.8/site-packages/geokit/core/regionmask.py:457: in buildMask
**kwargs).astype(np.bool)
attr = 'bool'
E AttributeError: module 'numpy' has no attribute 'bool'.
E
np.bool
was a deprecated alias for the builtinbool
. To avoid this error in existing code, usebool
by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, usenp.bool_
here.E The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
E https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
../../../miniconda3/envs/test_env/lib/python3.8/site-packages/numpy/init.py:305: AttributeError
The text was updated successfully, but these errors were encountered: