Remove unnecessary astpretty dependency #1164
Labels
Comments
ptheywood
changed the title
|
This impacts #1131 too |
It explains the comment in the conda recipe I.e. conda is correct, its not used. |
ptheywood
added a commit
that referenced
this issue
Dec 14, 2023
astpretty is only used for prettyprint debugging in codegen testing - it is not a pyflamegpu dependency. This commit also makes it an optional test_codegen.py dependency (but installs it in the test venv by default) Closses #1164
ptheywood
added a commit
that referenced
this issue
Dec 14, 2023
astpretty is only used for prettyprint debugging in codegen testing - it is not a pyflamegpu dependency. This commit also makes it an optional test_codegen.py dependency (but installs it in the test venv by default) Closses #1164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Astpretty is currently a pyflamegpu dependency in
setup.py.in.It is not actually used within pyfalemgpu's codegen module, only in a test.
It therefore is not a dependency of pyflamegpu, so should be removed from setup.py.in.
Usage within the test suite is also condition, guarded by an undefined variableDEBUG_OUT. This should be removed too, and can be added back in with the import if/when required.Usage within the test suite is guarded by a file-scoped variable
DEBUG_OUT, which is set to true.We can make this an optional dependency installed in the test environment alongside pytest.
The text was updated successfully, but these errors were encountered: