New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Korean: ㅊ should be romanized to "ch", but it's romanized to "c" #29

Open

anaclumos opened this issue Mar 22, 2024 · 1 comment

anaclumos commented Mar 22, 2024

Korean Romanization is Wrong · Issue #19907 · TryGhost/Ghost

I found that the corresponding code is this: https://github.com/FGRibreau/node-unidecode/blob/master/data/xcd.js

But I can't understand the array formula, so I'll stop digging into it here

Owner

FGRibreau commented Apr 8, 2024

this file should be updated: https://github.com/FGRibreau/node-unidecode/blob/master/data/x31.js
at index=74
to change "c" to "ch" :)

anaclumos added a commit to anaclumos/node-unidecode that referenced this issue


          Fixing FGRibreau#29

d2e0dc8

anaclumos mentioned this issue

Fixing https://github.com/FGRibreau/node-unidecode/issues/29 #30

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment