Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clan/{id} was removed, but game-client still uses it #459

Closed
fcaps opened this issue Nov 11, 2023 · 0 comments · Fixed by #519
Closed

clan/{id} was removed, but game-client still uses it #459

fcaps opened this issue Nov 11, 2023 · 0 comments · Fixed by #519
Assignees

Comments

@fcaps
Copy link
Collaborator

fcaps commented Nov 11, 2023

The game-client (chat -> right click on a user -> visit clan page) is opening the clan-page with https://clans.faforever.com/clan/{id}, but this route was removed.
There was some redirect in the code, but it got also removed with #410 .

// Compatibility
app.get('/clan/*', function (req, res){
  const id = req.path.split('/').slice(-1)[0];
  res.redirect('/clans/see?id='+id);
});

there is an issues open, but i would not opt to replace id with tag, just update the route clans with an s.

Till implemented in the game-client, we can enable the redirect again (when clans are working).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant