Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to join TMM team when already in game/match launching state. #963

Open
DotNetSimon opened this issue May 5, 2023 · 3 comments
Open
Labels

Comments

@DotNetSimon
Copy link

Describe the bug
When you invite someone before you search, they can accept after/while searching. We had a friend joining our team while we just found a match.

To Reproduce
Send invite, wait until match found and let other player accept the invite at that moment.

Log or error message
This is my log file:

Expected behavior
An error notification on the joining player's side that says something along the lines of "This team is already in the queue / already playing"

Screenshots
If applicable, add screenshots to help explain your problem.

OS
Linux or Windows

Wanna have the bug fixed quickly?
Visit Issue hunt...
Issue hunt

@DotNetSimon DotNetSimon added the bug label May 5, 2023
@DotNetSimon DotNetSimon changed the title Tighten up joining TMM team Possible to join TMM team when already in game/match launching state. May 5, 2023
@Sheikah45 Sheikah45 transferred this issue from FAForever/downlords-faf-client May 5, 2023
@Askaholic
Copy link
Collaborator

Probably makes sense to error out in that case. Nothing bad will happen with the searching or matching though since the searches are separate from the party. If you find a match, the player who joined late will simply not be included in the match. That’s probably a bit confusing from the user perspective though.

@benjamin-lawson
Copy link
Contributor

@Askaholic Would we want the behavior to be that if that party is currently searching, found a match, or currently in a match, would not be able to join the party? I think that would be more clear than to allow a player into a party but they aren't pulled in.

@Askaholic
Copy link
Collaborator

Yep, I think that makes sense too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants